Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the setter from the auditing interfaces. #13399

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Remove the setter from the auditing interfaces. #13399

merged 1 commit into from
Jul 26, 2022

Conversation

maliming
Copy link
Member

Resolve #12229

@maliming maliming requested a review from realLiangshiwei July 25, 2022 02:46
@maliming maliming added this to the 7.0-preview milestone Jul 25, 2022
@maliming maliming changed the base branch from rel-6.0 to dev July 25, 2022 02:47
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #13399 (e0b7e7b) into dev (90a50a7) will decrease coverage by 0.00%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##              dev   #13399      +/-   ##
==========================================
- Coverage   50.47%   50.47%   -0.01%     
==========================================
  Files        3212     3212              
  Lines       96408    96410       +2     
==========================================
  Hits        48660    48660              
- Misses      47748    47750       +2
Impacted Files Coverage Δ
...SettingManagement/SettingPageContributorManager.cs 0.00% <0.00%> (ø)
....Auditing/Volo/Abp/Auditing/AuditPropertySetter.cs 94.54% <87.50%> (ø)
...kCore/Volo/Abp/EntityFrameworkCore/AbpDbContext.cs 91.91% <100.00%> (ø)
...Domain/Repositories/MemoryDb/MemoryDbRepository.cs 88.17% <100.00%> (ø)
...p/Domain/Repositories/MongoDB/MongoDbRepository.cs 79.31% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@realLiangshiwei realLiangshiwei merged commit 8913e42 into dev Jul 26, 2022
@realLiangshiwei realLiangshiwei deleted the Auditing branch July 26, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realLiangshiwei realLiangshiwei realLiangshiwei approved these changes

Assignees
No one assigned
Labels
abp-framework breaking change
Projects
None yet
Milestone
7.0-preview
Development

Successfully merging this pull request may close these issues.

Remove setters from deletion and modification audit interfaces
2 participants
@maliming @realLiangshiwei